Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sigstore-java into several modules #284

Open
vlsi opened this issue Jan 13, 2023 · 2 comments
Open

Split sigstore-java into several modules #284

vlsi opened this issue Jan 13, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@vlsi
Copy link
Collaborator

vlsi commented Jan 13, 2023

Description

Currently, sigstore-java is all-in-one, so users can't select the bits they need, and the dependency surface might become an issue.

For instance, generating Sigstore Bundle requires protobuf-java which is 1.5M jar, and it often has CVEs: https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java

It guess it might work slightly better if we make sigstore-java an umbrella module with little to no code, and split the implementation to

WDYT?

@vlsi vlsi added the enhancement New feature or request label Jan 13, 2023
@patflynn
Copy link
Collaborator

patflynn commented Jan 13, 2023 via email

@vlsi
Copy link
Collaborator Author

vlsi commented Jan 13, 2023

I incline it might be easier to start by committing everything together (e.g. merge bundle into sigstore-java), and then try moving classes around to see if they really split :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants