Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10 signing] Add client signing configuration #1194

Open
haydentherapper opened this issue Apr 4, 2024 · 3 comments
Open

[v10 signing] Add client signing configuration #1194

haydentherapper opened this issue Apr 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

Tracking issue to add the new client signing configuration described in sigstore/protobuf-specs#277 for the next root/target signing

cc @kommendorkapten

@haydentherapper haydentherapper added the enhancement New feature or request label Apr 4, 2024
@haydentherapper haydentherapper changed the title [v10 root] Add client signing configuration [v10 signing] Add client signing configuration Apr 4, 2024
@jku
Copy link
Member

jku commented Apr 5, 2024

I am not opposed to another artifact in the repo but I'll mention these downsides so it's clear to everyone:

  • sigstore "client api" now includes the new proto. If a client that wants to use this data it needs parse this new file
  • sigstore "client api" now includes the targetpath used in the TUF repo
  • clients that want to use this data now need to download this targetpath with tuf

These are all reasonable but the last two items specifically are the price we pay for not just adding new optional fields into trusted_root.json.

@haydentherapper
Copy link
Contributor Author

I was re reading the client notes and I see it’s actually unclear what the decision was on whether or not this should be its own file. @kommendorkapten do you know what the conclusion was?

@kommendorkapten
Copy link
Member

@haydentherapper the overall agreement was to add a new file to not break anything for the existing clients.

It's listed here: (third bullet point: SigningConfig URLs from TUF)

New target (signing_config.json [agreed on naming])

As we call the trusted root trusted_root.json, we should call this signing_confg.json IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants