Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community membership guidelines #412

Merged
merged 1 commit into from May 13, 2024

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented Mar 11, 2024

Overall, the ladder structure remains the same, moving from a community member, to a project participant, to a project leader. The goal of these proposed changes is to encourage more community participation.

The primary difference is the change from a Triage role to a Reviewer role. "Triage" did not align well with GitHub permissions, and could be interpreted as granting the ability to review PRs without any control. I have clarified that the now-called "Reviewer" role should be granted the permission to approve a PR for merge, but not have the permission to merge it. This should hopefully encourage community members who are active in the codebase but not yet familiar with the entire project to participate more and become more familiar through code reviews.

I have also clarified the requirements of a codeowner and reviewer to emphasize their difference. A reviewer should have knowledge of the code but not necessarily a complete understanding of the codebase and its intricacies, while a codeowner should have a holistic understanding to determine when there are backward compatibility issues, security concerns, API breakage, etc.

With these changes, we can also move towards an entirely GH-team-based permission model, with "reviewer" and "codeowner" teams per-repo.

Fixes #52

Summary

Release Note

Documentation

Overall, the ladder structure remains the same, moving from a community
member, to a project participant, to a project leader. The goal of these
proposed changes is to encourage more community participation.

The primary difference is the change from a Triage role to a Reviewer
role. "Triage" did not align well with GitHub permissions, and could be
interpreted as granting the ability to review PRs without any control. I
have clarified that the now-called "Reviewer" role should be granted the
permission to approve a PR for merge, but not have the permission to
merge it. This should hopefully encourage community members who are
active in the codebase but not yet familiar with the entire project to
participate more and become more familiar through code reviews.

I have also clarified the requirements of a codeowner and reviewer to
emphasize their difference. A reviewer should have knowledge of the code
but not necessarily a complete understanding of the codebase and its
intricacies, while a codeowner should have a holistic understanding to
determine when there are backward compatibility issues, security
concerns, API breakage, etc.

With these changes, we can also move towards an entirely GH-team-based
permission model, with "reviewer" and "codeowner" teams per-repo.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper requested a review from a team as a code owner March 11, 2024 23:11
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks

@haydentherapper
Copy link
Contributor Author

Bump for reviews

@trevrosen
Copy link
Contributor

🚢

@bobcallaway bobcallaway requested a review from lukehinds May 9, 2024 15:08
@haydentherapper
Copy link
Contributor Author

Good to merge?

@bobcallaway bobcallaway merged commit c36aca3 into sigstore:main May 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outline process for maintainer promotion
5 participants