Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7 bytes of the VP8 payload unencrypted for non key frames #38

Open
lgrahl opened this issue Feb 8, 2022 · 3 comments
Open

7 bytes of the VP8 payload unencrypted for non key frames #38

lgrahl opened this issue Feb 8, 2022 · 3 comments

Comments

@lgrahl
Copy link

lgrahl commented Feb 8, 2022

There's an open todo you probably don't want left unresolved in production.

AFAIK this means that the first 7 bytes of the VP8 payload after the header are usually left unencrypted. The fix should be very simple by looking at the P bit (as done by your SFU) to determine whether to leave 3 or 10 bytes unencrypted.

@lgrahl lgrahl changed the title 7 bytes of the video frame left unencrypted for non key frames 7 bytes of the VP8 payload unencrypted for non key frames Feb 8, 2022
@ZagButNoZig
Copy link

@jrose-signal any updates on this? It still seems to be on main one year later. Is this a security/privacy concern?

@awaitlink
Copy link

Looks like there's some movement to make it encrypted: signalapp/webrtc#164.

@lgrahl
Copy link
Author

lgrahl commented Apr 4, 2024

Looks like there's some movement to make it encrypted: signalapp/webrtc#164.

Nah, that's just audio atm (although I'm not sure why one would need to leave parts of an audio frame unencrypted).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants