Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video playback does not stop when SIgnal window is closed #6661

Open
2 tasks done
joeda opened this issue Nov 6, 2023 · 2 comments · May be fixed by #6678
Open
2 tasks done

Video playback does not stop when SIgnal window is closed #6661

joeda opened this issue Nov 6, 2023 · 2 comments · May be fixed by #6678
Labels
Bug

Comments

@joeda
Copy link

joeda commented Nov 6, 2023 •
edited

  • I have searched open and closed issues for duplicates

  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

Playing a video and closing the window does not stop playback, audio keeps playing

Steps to Reproduce

  1. send video with audio to contact
  2. play video
  3. close window (not only video player)

Actual Result:

Audio keeps playing

Expected Result:

Video is stopped

Platform Info

Signal Version:

6.37.0

Operating System:

Windows 10 Pro 22H2

Link to Debug Log

https://debuglogs.org/desktop/6.37.0/0ecdb06f86be338c2b5dd3af4dd2ac5b7084144784df58896ba40231207624a3.gz
@Ross-Sherlock
Copy link

Working on a fix for this now.

Ross-Sherlock added a commit to Ross-Sherlock/Signal-Desktop that referenced this issue Nov 20, 2023
@Ross-Sherlock
Stop video playback on close to fix signalapp#6661
1fcce52 
Timeout is subject to change
@Ross-Sherlock Ross-Sherlock linked a pull request Nov 20, 2023 that will close this issue
Open
6 tasks
@ayumi-signal
Copy link
Contributor

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop video playback on close #6661 Ross-Sherlock/Signal-Desktop
4 participants
@joeda @Ross-Sherlock @jamiebuilds-signal @ayumi-signal