Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scale down images attached as "files" #6589

Closed
vvug opened this issue Apr 27, 2017 · 3 comments
Closed

Don't scale down images attached as "files" #6589

vvug opened this issue Apr 27, 2017 · 3 comments
Labels

Comments

@vvug
Copy link

vvug commented Apr 27, 2017

Sometimes there is the need for sending an image as-is, without further compression/scaling. As now Signal supports big and arbitrary attachment, please leave images alone when sending them as "Files" and not from the "Gallery".

The workaround now is renaming the file, but it's rather clunky on Android

@2-4601 2-4601 added the feature label Apr 29, 2017
@LoveIsGrief
Copy link

LoveIsGrief commented Jun 1, 2017

I'm interested, is this done in the app itself or on the server?

@FeuRenard
Copy link
Contributor

It's done around here in-app:
https://github.com/WhisperSystems/Signal-Android/blob/e96bf2bdc7a9cb7497eec696362c29a764d292d7/src/org/thoughtcrime/securesms/jobs/SendJob.java#L52

Media only leave your device encrypted (for Signal messages). I cannot imagine that there is a method which resizes encrypted media (e.g. on the server).

@automated-signal
Copy link

GitHub Issue Cleanup:
See #7598 for more information.

@signalapp signalapp locked and limited conversation to collaborators Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

5 participants