Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority mode for starred contacts ignored for calls #5503

Closed
2 tasks done
kwlg opened this issue May 21, 2016 · 3 comments
Closed
2 tasks done

Priority mode for starred contacts ignored for calls #5503

kwlg opened this issue May 21, 2016 · 3 comments

Comments

@kwlg
Copy link

kwlg commented May 21, 2016

I have:


Bug description

The priority mode in Marshmallow for starred contacts works as expected for messages but is ignored for calls. Thus, if I have priority mode enabled and a starred contact sends me a message, my notification signal is played and the phone vibrates as expected. However, if the same contact calls me via Signal, no sound is played and there is no vibration.

Steps to reproduce

  • Mark a contact as starred in the Contacts app.
  • Change the behaviour of priority mode so that only starred contacts get through. In the settings of Android:
    • Settings -> Sound & notification -> Do not disturb -> Priority only allows.
    • Change "Messages" and "Calls" to From starred contacts only
  • Enable priority mode
  • Have the starred contact call you and message you via Signal

Actual result:

  • For messages
    • Notification signal is played and vibration is felt when the starred contact sends a message via Signal
  • For calls
    • Ringtone is not played and vibration is not felt when the starred contact calls via Signal

Expected result:

  • For messages
    • Notification signal is played and vibration is felt when the starred contact sends a message via Signal
  • For calls
    • Ringtone is played and vibration is felt when the starred contact calls via Signal

Device info

Device: Google Nexus 5X
Android version: 6.0.1 (Google's official build)
Signal version: 3.15.2

App state

  • All app permissions allowed in Marshmallow's permissions settings
  • Signal messages and calls registered
  • SMS enabled
@cascheberg
Copy link
Contributor

I think this is an Android limitation. Signal uses a regular MediaPlayer to play the sound, which is muted automatically. Notifications instead are handled by the Android system. Also, the Android API for priority mode is almost nonexistent.

@luisvd
Copy link

luisvd commented Sep 24, 2016

I have a similar problem and it is related to the same issue.

The contact has a custom ringtone. The default sound for calls is vibrate.

If the contact calls on regular line the ringtone will work, if the contact uses signal for a call, the phone will vibrate using the default settings.

Apparently signal does not follow the contact ringtone settings therefore the do not disturb settings will not work.

Possible solutions:

  • Incorporate the call/messages notifications with the native android
  • A possible workaround would be selecting custom ringtones per contact just like notifications as a new feature.

@automated-signal
Copy link

GitHub Issue Cleanup:
See #7598 for more information.

@signalapp signalapp locked and limited conversation to collaborators Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants