Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send lossless images larger than about 5MB #13504

Open
sailbird opened this issue Apr 6, 2024 · 1 comment
Open

Cannot send lossless images larger than about 5MB #13504

sailbird opened this issue Apr 6, 2024 · 1 comment

Comments

@sailbird
Copy link

sailbird commented Apr 6, 2024


Bug description

If you hit the "+" and try to load up a lossless image from your gallery in preparation for sending, it will just appear black if it's larger than about 5MB. If you try to send it anyway, it will refuse to send.

Steps to reproduce

  1. Create a photo and save it losslessly to your gallery.
  2. Try to send it to someone.

Actual result: Describe here what happens after you run the steps above (i.e. the buggy behaviour)

Image just appears as black.

Expected result: Describe here what should happen after you run the steps above (i.e. what would be the correct behaviour)

It should send as usual.

I realize that Signal has limits to message size for economic reasons, but it always recompresses lossless images to lossy images, so the same should apply regardless of how large the input image is. If the image is so utterly large than even the lossiest JPEG quality setting isn't enough to crush it below the sendable threshold, then a downscaling followed by recompression would solve that. (NB downscaling is tricky because colormaps are nonlinear, but plenty has been written about that online.) Not saying this is trivial, but it's at least superficially an actual bug.

The quick-and-dirty "fix" is simply to increase the precompression size limit from, say, 5MB to 10MB or something like that. Moore's Law could make this an easy sell with management.

If even that's too much, then at least it would be nice to see an error message or a filler "photo" which just contains an error message.

Device info

Device: Samsung S23
Android version: 14
Signal version: (latest)

@nicholas-signal
Copy link
Contributor

Are you able to provide a debug log? And, if you feel comfortable, the problematic image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants