Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mergeable field to _PullRequest #1007

Closed
wants to merge 1 commit into from

Conversation

staticdev
Copy link
Collaborator

Closes #1005

@opendev-zuul
Copy link

opendev-zuul bot commented Oct 8, 2020

Starting third-party-check jobs.
Warning:
Failed to update check run openstack/third-party-check: 403 Resource not accessible by integration

@opendev-zuul
Copy link

opendev-zuul bot commented Oct 8, 2020

Build failed (third-party-check pipeline) integration testing on
OpenDev. For information on how to proceed, see
https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing

Warning:
Failed to update check run openstack/third-party-check: 403 Resource not accessible by integration
Failed to create check run openstack/third-party-check: 403 Resource not accessible by integration

@staticdev
Copy link
Collaborator Author

staticdev commented Oct 9, 2020

@sigmavirus24 I struggling to find why this create_review_comment integration test is giving IncompleteResponse: None The library was expecting more data in the response (KeyError(u'mergeable',)). Either GitHub modified it's response body, or your token is not properly scoped to retrieve this information..

@sigmavirus24 sigmavirus24 self-requested a review October 27, 2021 12:16
@sigmavirus24
Copy link
Owner

So if I run

r = gh.repository('sigmavirus24', 'github3.py')
next(r.pull_requests())

I get the exception in the tests which is that mergeable isn't in the collection of PRs response. The attribute is already present for the case where you get a specific PR, e.g., r.pull_request(1007) or if you next(r.pull_requests()).refresh().mergeable today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: expose mergeable attribute on ShortPullRequest
2 participants