Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Move import for gui elements #89

Merged
merged 1 commit into from Jun 9, 2021
Merged

Move import for gui elements #89

merged 1 commit into from Jun 9, 2021

Conversation

Muehli25
Copy link
Contributor

@Muehli25 Muehli25 commented Jun 8, 2021

Simple Fix for #88

@paulypeter
Copy link
Collaborator

That still wouldn't work when choosing to generate the config, or does it?

@Muehli25
Copy link
Contributor Author

Muehli25 commented Jun 8, 2021

I just moved the import. It's working fine in ubuntu desktop and ubuntu server. (atleast on my machine 😄 )

@sibalzer
Copy link
Owner

sibalzer commented Jun 9, 2021

I accept this as a temporary hotfix. But it shouldn't be the final solution. (contradicts PEP8, and the cli generation does not work on servers with this fix).

@paulypeter
Copy link
Collaborator

Could you try wrapping the tk import in a try-except block in config-generator.py instead?
Does it a raise a ModuleNotFoundError or an ImportError?

try:
    import tkinter as tk
    from tkinter import ttk
except Exception:
    ...

@sibalzer sibalzer merged commit 4d97f5d into sibalzer:main Jun 9, 2021
paulypeter added a commit to paulypeter/impfbot that referenced this pull request Jun 9, 2021
sibalzer added a commit that referenced this pull request Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants