Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

add appointment date to message #113

Merged
merged 3 commits into from Jun 13, 2021
Merged

Conversation

sibalzer
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #113 (316de48) into main (179b62a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   92.07%   92.11%   +0.03%     
==========================================
  Files          12       12              
  Lines         606      609       +3     
==========================================
+ Hits          558      561       +3     
  Misses         48       48              
Impacted Files Coverage Δ
tests/test_impfbot.py 100.00% <ø> (ø)
src/impfbot.py 87.50% <100.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179b62a...316de48. Read the comment docs.

paulypeter
paulypeter previously approved these changes Jun 12, 2021
src/impfbot.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@paulypeter paulypeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into a more permanent solution, but didn't find one I liked.. I guess this one is fine for a while

@sibalzer
Copy link
Owner Author

yea same, but we just need the date so it makes no difference if we get dd.mm.YYYY 01:00 during winter.

@paulypeter
Copy link
Collaborator

You're right, perfect

@paulypeter
Copy link
Collaborator

@sibalzer What would I have to do to merge this and release it as v3.1.0?

@sibalzer
Copy link
Owner Author

sibalzer commented Jun 13, 2021

i'll use the google release please action with semantic commit/merge messages:

  • fix: which represents bug fixes, and correlates to a SemVer patch.
  • feat: which represents a new feature, and correlates to a SemVer minor.
  • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.

this triggers the release please which creates a version pr and when i merge this the action creates a tag and deploys a new version

@sibalzer sibalzer merged commit 022cc03 into main Jun 13, 2021
@sibalzer sibalzer deleted the dev-earliest-vaccination-slot-date branch June 14, 2021 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants