Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

improves user input regexes #111

Merged
merged 2 commits into from Jun 12, 2021
Merged

improves user input regexes #111

merged 2 commits into from Jun 12, 2021

Conversation

paulypeter
Copy link
Collaborator

closes #109

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #111 (2496fcc) into main (d2443ec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   92.06%   92.07%   +0.01%     
==========================================
  Files          12       12              
  Lines         605      606       +1     
==========================================
+ Hits          557      558       +1     
  Misses         48       48              
Impacted Files Coverage Δ
src/common.py 97.91% <100.00%> (+0.04%) ⬆️
src/config_skeleton.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2443ec...2496fcc. Read the comment docs.

@paulypeter paulypeter changed the title more permissive user agent regex improves user input regexes Jun 12, 2021
@paulypeter paulypeter marked this pull request as draft June 12, 2021 14:24
@paulypeter paulypeter marked this pull request as ready for review June 12, 2021 14:32
@@ -7,10 +7,11 @@
APPOINTMENT_URL = r"https://www.impfportal-niedersachsen.de/portal/#/appointment/public"

ZIP_REGEX = r"^(19|21|26|27|28|29|30|31|34|37|38|48|49)([0-9]{3})$"
BIRTHDATE_REGEX = r"^[0-3]?[0-9]\.[0-3]?[0-9]\.(?:[0-9]{2})?[0-9]{2}$"
BIRTHDATE_REGEX = r"^[0-3]?[0-9]\.[0-3]?[0-9]\.(?:19|20)?[0-9]{2}$"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, dates like 1.1.0000 were allowed

@sibalzer sibalzer merged commit b925a01 into main Jun 12, 2021
@sibalzer sibalzer deleted the dev-fix-user-agent-regex branch June 12, 2021 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does the user_agent setting not allow spaces?
3 participants