Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Introduce Ntex web framework Service #1708

Open
1 task done
pavlospt opened this issue Apr 1, 2024 · 5 comments · May be fixed by #1707
Open
1 task done

[Feature]: Introduce Ntex web framework Service #1708

pavlospt opened this issue Apr 1, 2024 · 5 comments · May be fixed by #1707
Labels
S-Accepted This will be worked on T-Feature Request A request for a new feature

Comments

@pavlospt
Copy link

pavlospt commented Apr 1, 2024

Describe the feature

Hello, I would like to add Ntex us an option in Shuttle. I will open a PR for it and just raising this issue for awareness and contributing completeness. Will follow with Clerk example for Ntex as well :)

Suggestion or Example of how the feature would be used

No response

Duplicate declaration

  • I have searched the issues and this feature has not been requested before.
@pavlospt pavlospt added S-Triage Awaiting decision for what to do T-Feature Request A request for a new feature labels Apr 1, 2024
@pavlospt pavlospt linked a pull request Apr 1, 2024 that will close this issue
@jonaro00 jonaro00 added S-Accepted This will be worked on and removed S-Triage Awaiting decision for what to do labels Apr 2, 2024
@jonaro00
Copy link
Member

jonaro00 commented Apr 2, 2024

Thanks!
Feel free to make an examples PR for a hello-world example.
For the clerk example, do you envision it being a copy of the actix-web+clerk example, or something new?

@pavlospt
Copy link
Author

pavlospt commented Apr 2, 2024

Yes most probably it will be a copy with updated references since Ntex is like the successor of Actix!

@jonaro00
Copy link
Member

jonaro00 commented Apr 2, 2024

The clerk example uses an actix middleware in clerk-rs, so it might not be as simple as copy+pasting...
Moreover, having multiple variants of the same example can be a bit burdensome, especially the fullstack ones, so feel free to come up with something new that none of the other examples are using. Maybe there's some cool feature in ntex worth showing off and building an API around?

@pavlospt
Copy link
Author

pavlospt commented Apr 2, 2024

TBH Ntex and Actix are pretty similar so the same middleware structure can be built around it, but I will check it out if I am able to solve the runtime panic issue and come up with something new!

@sourabpramanik
Copy link
Contributor

TBH Ntex and Actix are pretty similar so the same middleware structure can be built around it, but I will check it out if I am able to solve the runtime panic issue and come up with something new!

Yes, we can create a middleware around it. For this example, it might be out of scope but I am willing to contribute to the middleware of clerk-rs lib for Ntex, and then you may use that. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Accepted This will be worked on T-Feature Request A request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants