Ruby 3.2 - unable to upgrade from 2.7.7 /gems/shrine-3.5.0/lib/shrine/storage/s3.rb:355:in `initialize': wrong number of arguments (given 1, expected 0) (ArgumentError)

[h0jeZvgoxFepBQ2C]

Hi,

we tried to upgrade to Ruby 3.2 from 2.7.7 but get following error, which we dont understand?
We have a custom storage class and initialize them with dynamic environment values - but its not working anymore due to the arguments changed?

# config/initializers/shrine.rb
class NoDeletionShrineS3Storage < Shrine::Storage::S3
  def delete(id)
    true
  end

  def delete_prefixed(delete_prefix)
    true
  end

  def clear!(&block)
    true
  end
end

s3StorageClass = Rails.env.development? ? NoDeletionShrineS3Storage : Shrine::Storage::S3

Shrine.storages = {
  ...
  do_spaces_private_store: s3StorageClass.new({..options}})
  ...
}

/usr/local/bundle/gems/shrine-3.5.0/lib/shrine/storage/s3.rb:355:in `initialize': wrong number of arguments (given 1, expected 0) (ArgumentError)
from /company/config/initializers/shrine.rb:55:in `new'
from /company/config/initializers/shrine.rb:55:in `<main>'
from /usr/local/bundle/gems/activesupport-6.1.5/lib/active_support/dependencies.rb:326:in `load'
from /usr/local/bundle/gems/activesupport-6.1.5/lib/active_support/dependencies.rb:326:in `block in load'
from /usr/local/bundle/gems/activesupport-6.1.5/lib/active_support/dependencies.rb:299:in `load_dependency'
from /usr/local/bundle/gems/activesupport-6.1.5/lib/active_support/dependencies.rb:326:in `load'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/engine.rb:681:in `block in load_config_initializer'
from /usr/local/bundle/gems/activesupport-6.1.5/lib/active_support/notifications.rb:205:in `instrument'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/engine.rb:680:in `load_config_initializer'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/engine.rb:634:in `block (2 levels) in <class:Engine>'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/engine.rb:633:in `each'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/engine.rb:633:in `block in <class:Engine>'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/initializable.rb:32:in `instance_exec'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/initializable.rb:32:in `run'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/initializable.rb:61:in `block in run_initializers'
from /usr/local/lib/ruby/3.2.0/tsort.rb:228:in `block in tsort_each'
from /usr/local/lib/ruby/3.2.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
from /usr/local/lib/ruby/3.2.0/tsort.rb:422:in `block (2 levels) in each_strongly_connected_component_from'
from /usr/local/lib/ruby/3.2.0/tsort.rb:431:in `each_strongly_connected_component_from'
from /usr/local/lib/ruby/3.2.0/tsort.rb:421:in `block in each_strongly_connected_component_from'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/initializable.rb:50:in `each'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/initializable.rb:50:in `tsort_each_child'
from /usr/local/lib/ruby/3.2.0/tsort.rb:415:in `call'
from /usr/local/lib/ruby/3.2.0/tsort.rb:415:in `each_strongly_connected_component_from'
from /usr/local/lib/ruby/3.2.0/tsort.rb:349:in `block in each_strongly_connected_component'
from /usr/local/lib/ruby/3.2.0/tsort.rb:347:in `each'
from /usr/local/lib/ruby/3.2.0/tsort.rb:347:in `call'
from /usr/local/lib/ruby/3.2.0/tsort.rb:347:in `each_strongly_connected_component'
from /usr/local/lib/ruby/3.2.0/tsort.rb:226:in `tsort_each'
from /usr/local/lib/ruby/3.2.0/tsort.rb:205:in `tsort_each'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/initializable.rb:60:in `run_initializers'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/application.rb:391:in `initialize!'
from /company/config/environment.rb:5:in `<main>'
from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
from /usr/local/bundle/gems/bootsnap-1.16.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32:in `require'
from /usr/local/bundle/gems/activesupport-6.1.5/lib/active_support/dependencies.rb:332:in `block in require'
from /usr/local/bundle/gems/activesupport-6.1.5/lib/active_support/dependencies.rb:299:in `load_dependency'
from /usr/local/bundle/gems/activesupport-6.1.5/lib/active_support/dependencies.rb:332:in `require'
from config.ru:25:in `block in <main>'
from /usr/local/bundle/gems/rack-2.2.6.2/lib/rack/builder.rb:116:in `eval'
from /usr/local/bundle/gems/rack-2.2.6.2/lib/rack/builder.rb:116:in `new_from_string'
from /usr/local/bundle/gems/rack-2.2.6.2/lib/rack/builder.rb:105:in `load_file'
from /usr/local/bundle/gems/rack-2.2.6.2/lib/rack/builder.rb:66:in `parse_file'
from /usr/local/bundle/gems/rack-2.2.6.2/lib/rack/server.rb:349:in `build_app_and_options_from_config'
from /usr/local/bundle/gems/rack-2.2.6.2/lib/rack/server.rb:249:in `app'
from /usr/local/bundle/gems/rack-2.2.6.2/lib/rack/server.rb:422:in `wrapped_app'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/commands/server/server_command.rb:77:in `log_to_stdout'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/commands/server/server_command.rb:37:in `start'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/commands/server/server_command.rb:144:in `block in perform'
from <internal:kernel>:90:in `tap'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/commands/server/server_command.rb:135:in `perform'
from /usr/local/bundle/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'
from /usr/local/bundle/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'
from /usr/local/bundle/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/command/base.rb:69:in `perform'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/command.rb:48:in `invoke'
from /usr/local/bundle/gems/railties-6.1.5/lib/rails/commands.rb:18:in `<main>'
from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
from /usr/local/bundle/gems/bootsnap-1.16.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32:in `require'

Any idea? Thank you for this wonderful upload library, much better then everything else! ❤️

[janko]

Ruby 3.0 introduced backwards incompatible changes regarding interchangeability of hashes and keyword arguments. If a method like Shrine::Storage::S3#initialize accepts keyword arguments, and you have a hash of options, you now need to explicitly convert it to keyword arguments when passing to the method using **:

do_spaces_private_store: s3StorageClass.new(**options)