App script macros return Twig\Markup instance instead of actual return value

[atloss]

PHP Version

8.2

Shopware Version

6.6.1.1

Expected behaviour

App script macros return the actual return value.

Actual behaviour

App script macros return Twig\Markup instance.

How to reproduce

1. Create a valid app based on the app system with bin/console app:create
2. Create an app script. E.g Resources/scripts/navigation-page-loaded/load-navigation-page.twig
3. Use the following sample code for the load-navigation-page.twig script:

{% import 'include/loader.twig' as loader %}

{% set page = hook.page %}
{# @var page \Shopware\Storefront\Page\Navigation\NavigationPage #}

{% do loader.load() %}

4. Next up create the Resources/scripts/include/loader.twig include with something like:

{# @var services \Shopware\Core\Framework\Script\ServiceStubs #}

{% macro load() %}
    {% set text = _self.sayHello() %}
    {% do debug.dump(text) %}
{% endmacro %}

{% macro sayHello() %}
    {% return "Hello World" %}
{% endmacro %}

6. Expected behaviour: The macro function returns the Hello World string
7. Actual behaviour: The macro function returns a Twig\Markup instance

---

Consequences: This results in crashing apps, since those macros don't return expected values anymore.

[shopware-issue-bot]

We found the following existing issues which may help or are related to your topic:

• Apps: Twig set function doesn't work
• Support for Twig Block function
• sw_get_attribute extension and Script Rules are broken with Twig 3.9

[shyim]

We are working on it. in the meanwhile you can run

composer req shopware/conflicts:0.1.7 -W