Original cart deliveries are changed in DeliveryProcessor

[nexxome]

PHP Version

8.2

Shopware Version

6.5.8.8

Expected behaviour

The original cart should not be changed in cart processors

Actual behaviour

Deliveries in the original cart are changed in DeliveryProcessor

How to reproduce

For example convert an existing order to a cart and run the processors:

$cart = $this->orderConverter->convertToCart($existingOrder, $context); $behavior = new CartBehavior($salesChannelContext->getPermissions()); $cart = $this->processor->process($cart, $salesChannelContext, $behavior);

The deliveries from the original cart should be cloned and not changed for the calculation of the new cart:

`
$deliveries = $original->getDeliveries();
$firstDelivery = $deliveries->first();
if ($firstDelivery === null) {
return;
}

// Stored original edit shipping cost
$manualShippingCosts = $toCalculate->getExtension(self::MANUAL_SHIPPING_COSTS) ?? $firstDelivery->getShippingCosts();

$toCalculate->addExtension(self::MANUAL_SHIPPING_COSTS, $manualShippingCosts);

if ($manualShippingCosts instanceof CalculatedPrice) {
    $firstDelivery->setShippingCosts($manualShippingCosts);
}

$this->deliveryCalculator->calculate($data, $toCalculate, $deliveries, $context);

$toCalculate->setDeliveries($deliveries);

`

[shopware-issue-bot]

We found the following existing issues which may help or are related to your topic:

• Delivery Processor and Delivery Builder need to respect original entity ids
• Original carts missing in CartMergedEvent
• CartService returns wrong cart
• recalculateOrder changes shipping method
• Cart settings delivery time and instock
• CartService deletes wrong cart
• Cannot change delivery and invoice address