Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-34924 - Fix installer fr translation file #3651

Conversation

michaelthieulin
Copy link
Contributor

@michaelthieulin michaelthieulin commented Apr 8, 2024

1. Why is this change necessary?

We can't go throw the installer in French because the file is not valid YAML.

2. What does this change do, exactly?

This change fix the specified file.

3. Describe each step to reproduce the issue or behaviour.

Steps to reproduce is described here

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

Fix #3650

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024

CLA assistant check
All committers have signed the CLA.

@michaelthieulin michaelthieulin force-pushed the fix-installer-fr-translation-file branch from 43003db to c13ca0c Compare April 8, 2024 15:16
@shopware-github-importer shopware-github-importer bot changed the title Fix installer fr translation file NEXT-34924 - Fix installer fr translation file Apr 9, 2024
@michaelthieulin michaelthieulin deleted the fix-installer-fr-translation-file branch April 11, 2024 09:00
@mitelg
Copy link
Member

mitelg commented Apr 16, 2024

thanks for your contribution @michaelthieulin 👍🎉💙

@michaelthieulin
Copy link
Contributor Author

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer french translation yaml file is broken
6 participants