Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Quotes of font names are missing from --bs-body-font-family in all.css #3620

Open
Saiyan opened this issue Mar 20, 2024 · 1 comment

Comments

@Saiyan
Copy link

Saiyan commented Mar 20, 2024

PHP Version

8.1

Shopware Version

6.5.8.2 - 6.5.8.7

Expected behaviour

When using quotes to surround font names with spaces the quotes should still appear in the compiled theme css.

Actual behaviour

Quotes are omitted for the --bs-body-font-family variable

How to reproduce

Boot up a fresh instance of Shopware v6.5.8.2. Go to theme settings and change the "Fonttype text" to something like "Times New Roman", monospace. Now open up the current all.css file and look for the declaration of --bs-body-font-family inside root {...}
The Quotes are missing and if the font is not installed on the clients PC monospace is used instead.

image

This bug could break all themes that fulfill all three of these criteria

  • inherits the shopware default theme
  • uses font family names with spaces
  • overrides the default font via sw-font-family-base or font-family-base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants