Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated code ->setParameters( #3592

Open
lxregistry opened this issue Mar 5, 2024 · 1 comment
Open

deprecated code ->setParameters( #3592

lxregistry opened this issue Mar 5, 2024 · 1 comment
Labels
Bug Good first issue Good Issue for your first contribution or experimenting with Shopware

Comments

@lxregistry
Copy link
Contributor

lxregistry commented Mar 5, 2024

PHP Version

8.3.3

Shopware Version

6.6.0.0.RC.3

Expected behaviour

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\Query\Parameter;

$builder->setParameters(new ArrayCollection([
new Parameter('techName', InvoiceRenderer::TYPE),
new Parameter('orderId', Uuid::fromHexToBytes($orderId))
]));

Actual behaviour

$builder->setParameters([
'techName' => InvoiceRenderer::TYPE,
'orderId' => Uuid::fromHexToBytes($orderId),
]);

How to reproduce

in
src/Core/Checkout/Document/Service/ReferenceInvoiceLoader.php and in others files where is ->setParameters(

this deprecated code will result in error in version 4.0
https://www.doctrine-project.org/projects/doctrine-orm/en/3.0/reference/query-builder.html
https://www.doctrine-project.org/projects/doctrine-orm/en/latest/reference/query-builder.html

@lxregistry lxregistry added the Bug label Mar 5, 2024
@mitelg mitelg added the Good first issue Good Issue for your first contribution or experimenting with Shopware label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Good first issue Good Issue for your first contribution or experimenting with Shopware
Projects
None yet
Development

No branches or pull requests

2 participants