Twig map filter can not use key

[kingschnulli]

PHP Version

Any

Shopware Version

6.5.8.6 / trunk

Expected behaviour

Consider the following twig template in storefront, reduced for clarity:

{% set itemStyles = {
    border: '1px solid #000',
    padding: '15px'
%}
<div style="{{ itemStyles|map((cssValue, cssProperty) => "#{cssProperty}: #{cssValue}")|join(';') }}">
...
</div>

This will fail with an exception from SecurityExtension

Too few arguments to function __TwigTemplate_e2e6dd84c91e95ce276fd9aafe10abd0::{closure}(), 1 passed in /var/www/html/vendor/shopware/core/Framework/Adapter/Twig/SecurityExtension.php on line 54 and exactly 2 expected

The SecurityExtension ignores the fact that Twigs map function closure can take up to 2 arguments - see Twig Docs

Actual behaviour

The twig compiler should not fail, map is an allowed function and should work as expected.

How to reproduce

Run the twig template in the storefront:

{% set itemStyles = {
    border: '1px solid #000',
    padding: '15px'
%}
<div style="{{ itemStyles|map((cssValue, cssProperty) => "#{cssProperty}: #{cssValue}")|join(';') }}">
test
</div>

[shopware-issue-bot]

We found the following existing issues which may help or are related to your topic:

• Twig-Filter json_encode ignores Flag
• Fix UrlEncodingTwigFilterTest
• Apps: Twig set function doesn't work
• [Github] NEXT-00000 Fix UrlEncodingTwigFilterTest
• Missing Twig variables in e-mail templates
• NEXT-32039 Fix UrlEncodingTwigFilterTest
• Twig block spelling error in the standard contact form

[shyim]

Can you make a PR? should be simple fixed :)

[kingschnulli]

Sure will do - just wanted to know if this is was intended or a bug

[shyim]

It was not intended :)