Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github actions: check phpstan on the split packages #2929

Open
vitek-rostislav opened this issue Nov 23, 2023 · 0 comments
Open

github actions: check phpstan on the split packages #2929

vitek-rostislav opened this issue Nov 23, 2023 · 0 comments
Labels
In Backlog

Comments

@vitek-rostislav
Copy link
Contributor

vitek-rostislav commented Nov 23, 2023 •
edited

Describe the bug

At the moment, for the split packages, on the GitHub actions, we check phpstan for the framework package only (https://github.com/shopsys/shopsys/blob/14.0/packages/framework/.github/workflows/run-checks-tests.yaml#L29). We should do that for all the packages (+ project base).

Note: Besides modifying the run-checks-tests.yaml in the packages, we will need to add the phpstan dependencies to the packages as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In Backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vitek-rostislav