Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrator is announcing Tab items present inside the 'Edit your manifest' dialogue as 'Group'. #1744

Open
msftedad opened this issue Nov 27, 2023 · 4 comments
Assignees
Labels
a11y Anything relating to accessibility. bug Things that aren't working right in the library. help wanted Ready for a contributor to tackle.

Comments

@msftedad
Copy link

Describe the bug

Narrator is announcing Tab items present inside the 'Edit your manifest' dialogue as 'Group'. If the proper role as tab will not be announced by the narrator, then the screen reader users will not get the information of the control and they may get confused.

To Reproduce

  1. Open the PWA Builder URL- https://www.pwabuilder.com/reportcard?site=https://webboard.app.
  2. PWA Builder page will appear.
  3. Navigate to the 'Edit your Manifest' button activate it.
  4. Turn on the narrator using Ctrl + Win + Enter.
  5. Dialogue will appear now navigate to the tab items info, setting, platforms, etc.
  6. Observe the narrator's announcement.

Demo

https://www.pwabuilder.com/reportcard?site=https://webboard.app

Screenshots

Narrator is announcing Tab items present inside the 'Edit your manifest' dialogue as 'Group'

Narrator.is.announcing.Tab.items.present.inside.the.Edit.your.manifest.dialogue.as.Group.mp4

Browser / OS

OS: Windows11
OS Version: 23H2 (Build 25905.1000)
Browser: Edge Dev (Version 117.0.2007.0 (Official build) dev (64-bit))
Screen reader: Narrator

Additional information

Issue is also repro at https://www.pwabuilder.com/reportcard?site=https://example.com

@msftedad msftedad added the bug Things that aren't working right in the library. label Nov 27, 2023
@claviska claviska added help wanted Ready for a contributor to tackle. a11y Anything relating to accessibility. labels Nov 27, 2023
@msftedad
Copy link
Author

msftedad commented Feb 9, 2024

Hi team, Any update on this issue?

@claviska
Copy link
Member

I'm not currently setup to test in Narrator, but a PR from the community would be very welcome to help out here.

@claviska
Copy link
Member

@msftedad Can you confirm the same behavior happens in the docs? https://shoelace.style/components/tab-group

If so, this is a Narrator issue. If not, it could be an implementation issue. I can confirm that VoiceOver is announcing the tabs correctly in your demo.

@msftedad
Copy link
Author

Hi @claviska , we are in discussion with PO team.Once we receive information from them we promptly update you.Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Anything relating to accessibility. bug Things that aren't working right in the library. help wanted Ready for a contributor to tackle.
Projects
None yet
Development

No branches or pull requests

3 participants