Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing redirects for domains not yet used in any short URL or new domains #239

Open
acelaya opened this issue Aug 21, 2021 · 1 comment
Labels

Comments

@acelaya
Copy link
Member

acelaya commented Aug 21, 2021

Summary

Currently, only the domains displayed in "Manage domains" allow editing the redirects.

Allow setting up redirects for new domains/domains not yet used on short URLs, as the REST API supports it, and it would match the behavior of the CLI command.

@acelaya
Copy link
Member Author

acelaya commented Dec 26, 2021

Blocking this, as it has some considerations.

  • Shlink only returns domains that have either been used for some short URL, or have some redirect explicitly configured. That means that "creating" a new domain with no redirects will make Shlink to not return it.
  • Even if at least one redirect is enforced for "new domains", once created, you no longer know if the domain is used in some URL or not, so the user could edit it afterwards and remove the redirect/s.
    • This could be mitigated if Shlink returned the amount of URLs in which the domain is used.

@acelaya acelaya transferred this issue from shlinkio/shlink-web-client Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant