Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add services needed for sessions and end-user authentication #40

Merged
merged 7 commits into from
May 16, 2024
Merged

Add services needed for sessions and end-user authentication #40

merged 7 commits into from
May 16, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented May 14, 2024

Closes #8

@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited

Codecov Report

Attention: Patch coverage is 81.42077% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 65.90%. Comparing base (8d4071e) to head (05dc13e).
Report is 4 commits behind head on main.

Files Patch % Lines
app/root.tsx 0.00% 14 Missing and 1 partial ⚠️
app/auth/auth.server.ts 85.71% 0 Missing and 5 partials ⚠️
app/routes/login.tsx 91.93% 0 Missing and 5 partials ⚠️
app/users/UsersService.server.ts 77.27% 0 Missing and 5 partials ⚠️
app/auth/passwords.server.ts 66.66% 0 Missing and 2 partials ⚠️
app/auth/session.server.ts 95.23% 0 Missing and 1 partial ⚠️
app/routes/server.$serverId.$.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   61.28%   65.90%   +4.61%     
==========================================
  Files          15       21       +6     
  Lines         607      786     +179     
  Branches       60       79      +19     
==========================================
+ Hits          372      518     +146     
- Misses        175      189      +14     
- Partials       60       79      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya marked this pull request as ready for review May 16, 2024 07:37
@acelaya acelaya merged commit 429f7d9 into shlinkio:main May 16, 2024
6 checks passed
@acelaya acelaya deleted the feature/user-session branch May 16, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add login and session handling
1 participant
@acelaya