From e45de0014f1f011e81b2d0035d98cdd7216888c3 Mon Sep 17 00:00:00 2001 From: Shiv Jha-Mathur Date: Mon, 8 Nov 2021 02:39:30 +0530 Subject: [PATCH] refactor: rename `getTags` to `getImages` --- main.go | 6 +++--- main_test.go | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/main.go b/main.go index eb764e7..9faf75e 100644 --- a/main.go +++ b/main.go @@ -37,7 +37,7 @@ func main() { log.Fatalf("Could not parse Dockerfile: %s\n", err) } - images := getTags(parsed, unknownMarker) + images := getImages(parsed, unknownMarker) val, err := json.Marshal(images) @@ -82,8 +82,8 @@ func getInput(args []string) (*os.File, error) { return os.Stdin, nil } -// getTags returns the `Image`s used in the given sets of Dockerfile commands. -func getTags(commands []dockerfile.Command, unknownMarker string) []Image { +// getImages returns the `Image`s used in the given sets of Dockerfile commands. +func getImages(commands []dockerfile.Command, unknownMarker string) []Image { images := []Image{} for _, cmd := range commands { diff --git a/main_test.go b/main_test.go index 531d76b..eb501ab 100644 --- a/main_test.go +++ b/main_test.go @@ -23,7 +23,7 @@ func TestParsing(t *testing.T) { t.Errorf("Could not open Dockerfile.1: %s", err) } - tags := getTags(commands, " * ") + tags := getImages(commands, " * ") assert.Equal(t, expected, tags) } @@ -46,7 +46,7 @@ func TestQuery(t *testing.T) { t.Errorf("Could not open Dockerfile.1: %s", err) } - tags := getTags(commands, "?") + tags := getImages(commands, "?") for _, c := range cases { result, err := getSingleTag(tags, c.query)