Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Docking Port doesn't work well enough #1420

Open
Latentish opened this issue Aug 3, 2022 · 1 comment
Open

[Issue] Docking Port doesn't work well enough #1420

Latentish opened this issue Aug 3, 2022 · 1 comment
Labels
Able to Reproduce Help Wanted Extra attention is needed. High Priority We messed up.

Comments

@Latentish
Copy link
Member

Latentish commented Aug 3, 2022

Round ID:

I replicated this numerous times on local test, and this is a well known issue on live. No round ID.

Testmerges:

Tested on local without any testmerges, and easily found on rounds without any test merges.

Reproduction:

Ports do not work as they should, or they do not work in a way that is understandable or consistent. The Docking Port map helper that you place on your ship's port controls 3 things with 2 values.
It uses the two values of "port_direction" and "preferred_direction", which control port direction, preferred direction, and the direction moving space flows. No amount of fiddling with these values can consistently make a ship not turn. A ship that is equal to or less than 40/40 will have an issue with turning right or left when they land. Making a ship x >= 41 will prevent it turning sideways, and in most cases prevent the ship from turning whatsoever. But if the ship faces any direction but north, or has thrusters facing any direction but south, is prone to having unresolveable issue with turning and space movement. Let alone if the port and thrusters face the same direction. Setting the port and preferred direction to opposites sometimes lets the ship not turn, but if the ship faces south then either the ship must flip upside down permanently, or make space flow in the wrong direction. If that same ship has an x<=40, it will turn sideways, and cannot be made to not turn under any circumstances.
Unwanted shipturning on landing is the most well known issue on shiptest by the average player, and is usually the first one people notice. Shipturning is caused by the fact that docking ports just do not work properly or well. They need an additional value, and they need to not force a sideways turn on small ships.

If you would like an easy way to reproduce this issue, just fiddle with the docking port of the Ranger-Class, along with its x value.

@Latentish Latentish added Bug Something isn't working Able to Reproduce High Priority We messed up. labels Aug 3, 2022
@Latentish
Copy link
Member Author

Yes I am making my own issue high priority and reproduceable.

@Latentish Latentish changed the title [BUG] Docking Port doesn't work [Issue] Docking Port doesn't work well enough Aug 3, 2022
@ZephyrTFA ZephyrTFA added the Help Wanted Extra attention is needed. label Aug 3, 2022
@Latentish Latentish pinned this issue Aug 4, 2022
@MarkSuckerberg MarkSuckerberg removed the Bug Something isn't working label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Able to Reproduce Help Wanted Extra attention is needed. High Priority We messed up.
Projects
None yet
Development

No branches or pull requests

3 participants