Handle errors spanning multiple tokens #145
Open
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e501f8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
with-heart
force-pushed
the
handle-errors-spanning-multiple-tokens
branch
from
3940997
to
e501f8c
Compare
|
The - <data-lsp lsp='const todo: Readonly<Todo>' >todo</data-lsp>.<data-err><data-lsp lsp='(property) title: any' >title</data-lsp></data-err>
+ <data-lsp lsp='const todo: Readonly<Todo>' >todo</data-lsp>.<data-lsp lsp='(property) title: any' >title</data-lsp>It shows that it's not rendering
Any ideas? |
|
Oof, not sure when I'll find time to dig into this properly - this section of code is super gnarly and not an area I fully grok anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #144 by creating a new function that checks whether each token is within the range of an error (
e.charactertoe.character + e.length). Checking the range produces the correct results (T[Key]is highlighted as an error):This function replaces
findTokenFunconly when handling errors (lsp responses + queries still usefindTokenFunc).I also added
isTokenWithinErrorRangeDebugwhich is similar tofindTokenFuncDebugfor any future debugging needs.