Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorations: Allow intersections #592

Open
3 of 4 tasks
zhangtao25 opened this issue Feb 18, 2024 · 2 comments
Open
3 of 4 tasks

Decorations: Allow intersections #592

zhangtao25 opened this issue Feb 18, 2024 · 2 comments
Labels
help-wanted Extra attention is needed

Comments

@zhangtao25
Copy link

Clear and concise description of the problem

I'm working on a hydrated version of the Istanbul report, and there will be some overlapping tagging situations that will prompt intersections when using the shiki.

Suggested solution

I would like to be able to turn on whether or not to check for intersections via configuration.

Alternative

No response

Additional context

No response

Validations

Contributes

  • If this feature request is accepted, I am willing to submit a PR to fix this issue
@antfu
Copy link
Member

antfu commented Feb 18, 2024

It's just not possible to create that DOM structure - if you have any idea to solve that PR welcome

@antfu antfu added the help-wanted Extra attention is needed label Feb 18, 2024
@zhangtao25
Copy link
Author

It's just not possible to create that DOM structure - if you have any idea to solve that PR welcome

I migrated from highlight.js because of the lack of code block decorating functionality. I also investigated Codemirror, but the package size was too big, and all I wanted was block highlighting. shiki provides block decoration, which is very important to me. I plan to check out shiki code and make a PR.

@antfu antfu changed the title verify-intersections: permitted intersections Decorations: Allow intersections Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants