Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket pair colorization #303

Open
theoludwig opened this issue Feb 22, 2022 · 4 comments
Open

Bracket pair colorization #303

theoludwig opened this issue Feb 22, 2022 · 4 comments

Comments

@theoludwig
Copy link

Hey! 馃憢

Thanks for this awesome package, I can finally use VSCode default Dark+ theme syntax highlighting on my blog. 馃槃
I'm wondering if Bracket pair colorization could be added to Shiki? It has been added to VSCode natively since v1.60 with settings.json: "editor.bracketPairColorization.enabled": true.

With VSCode:

image

With Shiki

image

@muenzpraeger
Copy link
Collaborator

That should be in now with 0.12.0.

@theoludwig
Copy link
Author

That should be in now with 0.12.0.

How do you enable it? It seems like it is not enabled by default? I updated to shiki@0.12.1, and there is still no bracket pair colorization. @muenzpraeger

@muenzpraeger
Copy link
Collaborator

@divlo VSCode itself has built-in bracket-pair colorization (based on runtime inspection of the code). If that should be replicated in a non-IDE situation like here with Shiki the tmLangauge definition as well as the the used theme have to provide that information.

@octref
Copy link
Collaborator

octref commented Jan 26, 2023

This requires extracting the VS Code bracket pair colorization logic out and bringing it to shiki. I don't quite have the bandwidth to do it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants