Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disregard shapes outside projection space #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disregard shapes outside projection space #35

wants to merge 1 commit into from

Conversation

mmv
Copy link

@mmv mmv commented Aug 18, 2018

When some points are outside projection space, they're stored as null. Later in the code, there's an attempt to get the [0] coordinate of that null, which breaks everything.

This change disregards those shapes and issues a console warning about the cause.

Should fix #22

@shawnbot shawnbot self-assigned this Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shawnbot shawnbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property '0' of null
2 participants
@mmv @shawnbot