Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python logging module instead of print statements #548

Open
sharkwouter opened this issue Nov 25, 2022 · 2 comments
Open

Use python logging module instead of print statements #548

sharkwouter opened this issue Nov 25, 2022 · 2 comments

Comments

@sharkwouter
Copy link
Owner

At the moment we have a lot of print statements and we have a debug mode. This could be done better with the logging module. It could be a global logger. The logs should be written to a file.

@orende
Copy link
Contributor

orende commented Jul 12, 2023

This has been done as part of #573 except for this line which I can't quite figure out if it's intentionally using a print statement or not.

@sharkwouter
Copy link
Owner Author

True, I'll go over our implementation one more time and see if we're at the point where it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants