Add pastel --layout {horizontal,vertical,detail}
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Detail' remains the default layout. The layout can also be set as -v or -h as program arguments (which displaces the old `pastel -h`, which printed help) or by setting the PASTEL_LAYOUT environment variable. - readme video out of date - Didn't try compiling w/ rustc 1.43.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Detail' remains the default layout. The layout can also be set as -v or -h as program arguments (which displaces the old
pastel -h, which printed help) or by setting the PASTEL_LAYOUT environment variable.Closes #137
Actually this PR isn't good enough to go in. However I will leave it here in case someone is looking for it.
Layout::Verticalis worthless compared to the vertical layout made by some of the other commands.The command trait and the macro to help implement it are unnecessary ceremony. AFAICT the commands are all just outputting lists of colors with various different layouts. It would best to store them as
&[(name, default_layout, fn(...) -> Vec<Color>)]