Allow GitHub URLs to be set in settings to support GitHub Enterprise and Enterprise Cloud

[jonruiz]

Tartelet hardcodes the Server and API URLs to GitHub.com. It would be nice if these could be overridden in settings to support GitHub Enterprise and Enterprise cloud.

[jonruiz]

I tried to do this locally. I was able to get around signing issues by changing the Bundle Identifier, then ran into issues with keychain access, but will keep it on the radar.

artelet is awesome. Nice work!

[simonbs]

@jonruiz This is a great idea! I'm happy to review a PR that adds this.

[mattia]

I tried to do this locally. I was able to get around signing issues by changing the Bundle Identifier, then ran into issues with keychain access, but will keep it on the radar.

artelet is awesome. Nice work!

Regarding the keychain issue, did you also update the keychain implementation in CompositionRoot.swift (here)? At the moment it has hardcoded the value, after updating it I was able to have the project running without issues

[jonruiz]

Ah yes thank you. That works for me too. Much appreciated!

[mattia]

Hi! 👋
If you are still interested I've opened a (very much) draft PR (#53) that should work. You are welcome to test it, but you will need to compile your own Tartelet version.
Let me know if it works!