Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for React 16 #1469

Open
alexeyr-ci1 opened this issue Jul 7, 2022 · 1 comment
Open

Add integration tests for React 16 #1469

alexeyr-ci1 opened this issue Jul 7, 2022 · 1 comment
Labels
contributions: up for grabs! enhancement

Comments

@alexeyr-ci1
Copy link
Collaborator

Since spec/dummy is now using React 18 (#1463), and we still want compatibility with React 16, we need integration tests for React 16. Could add an example to generators, but I am not sure that's enough (still better than nothing).

@justin808 What do you think? Anyone we could assign this to?
@justin808
Copy link
Member

Ideally, we'd swap the dependency with an ENV flag so that spec/dummy can run on React 16. However, I don't see that as a priority right now.

I'll leave this one up for grabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions: up for grabs! enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justin808 @alexeyr-ci1