Summary of known compiler issues

[seanbecker15]

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?
Yes

If the question is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?
3.2.1

What browser and OS are you using?
Too many to list :)

Please ask your question
We are currently using the debug version of Shaka in production because we have noticed issues with the compiled version of 3.2.1. Upgrading versions is on our roadmap, but I recall reading a few thread that related to compiler issues. I also recall reading about a large change to the compiler near the time of 3.x or 4.x. Any way we could get some more information about what was changed and how the compiler behaves differently? Links to relevant issues, PRs, and commits would all be greatly appreciated. Anything would help.

For reference, I searched through the issues and PRs but it seems like this might be something that spans over quite a few issues and quite a few years, so figured it might be best to just ask for a summary.

[joeyparrish]

Sorry, we don't have any such list here. You can look at the changelog of the compiler: https://github.com/google/closure-compiler and compare that to the history of package.json where we made compiler changes.

Our last update to the compiler was 28b73b9 in Nov 2022, and before that it was 6f274cb in March 2022, and before that it was c482e81 in February 2022, and before that it was 8779715 in May 2021.

I found these by git log -p package.json and then searching for ^-.*compiler-java.

We don't plan to upgrade the Closure Compiler again, as we hope to move to TypeScript later this year.

I hope that helps!

[seanbecker15]

@joeyparrish that helps a lot, thanks! Looking forward to the TypeScript upgrade. We've currently got a shim that interfaces with Shaka but with TS support we could probably remove that shim.

Feel free to close this issue at your convenience.