Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaka 4.6.16 doesn't show WebVTT subtitles #6448

Open
TommiRautanen opened this issue Apr 16, 2024 · 10 comments
Open

Shaka 4.6.16 doesn't show WebVTT subtitles #6448

TommiRautanen opened this issue Apr 16, 2024 · 10 comments
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically type: bug Something isn't working correctly
Milestone

Comments

@TommiRautanen
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not related

What version of Shaka Player are you using?

Works fine with 4.3.4, but not with 4.6.16 / 4.7.12

Can you reproduce the issue with our latest release version?
I'm using Shaka in Chromecast so 4.7.12 is the latest I'm able to try out.

Can you reproduce the issue with the latest code from main?

Are you using the demo app or your own custom app?
Custom Chromecast receiver

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Chromecast

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

Example of failing WebVTT content:

WEBVTT
X-TIMESTAMP-MAP=MPEGTS:2627320000,LOCAL:00:00:00.000

902788007
00:00:02.320 --> 00:00:03.840
-Aja jo!
-Paljonko saimme?

What configuration are you using? What is the output of player.getConfiguration()?

Default config.

What did you do?

Start playing live content. With Shaka 4.3.4 subtitles are showing up, with 4.6.16 / 4.7.12 they are not.

What did you expect to happen?
Subtitles should show up.

What actually happened?

Cues are not being updated to videoElement:
Screenshot 2024-04-16 at 8 19 30

@TommiRautanen TommiRautanen added the type: bug Something isn't working correctly label Apr 16, 2024
@joeyparrish
Copy link
Member

Quoting the issue template:

**What are the manifest and license server URIs?**
<!-- NOTE:
  You can send the URIs to <shaka-player-maintainers@googlegroups.com> instead,
  but please use GitHub and the template for the rest.
  A copy of the manifest text or an attached manifest will **not** be
  enough to reproduce your issue, and we **will** ask you to send a
  URI instead.

@joeyparrish joeyparrish added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Apr 16, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Apr 16, 2024
@TommiRautanen
Copy link
Author

@joeyparrish sorry, this is DRM protected stream so cannot provide manifest URL. But issue is with HLS CMAF stream + WebVTT subtitles.

HLS TS works OK.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Apr 16, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 16, 2024

Since you cannot provide a test stream, we cannot help you further. If you want to debug the issue yourself and create a PR, we will be happy to review it.

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Apr 16, 2024
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Apr 23, 2024
@CarlLindqvist
Copy link

I managed to recreate it for VOD when snipping from a live stream. The live stream uses UTC timecode, and my guess is that Shaka doesn't translate the WebVTT timecodes correctly because of TS rollover. Maybe because of the work done in #6320

Here is a test stream:
https://downloads.a2d.tv/subsissue/subsissue.m3u8

@CarlLindqvist
Copy link

@shaka-bot reopen

1 similar comment
@TommiRautanen
Copy link
Author

@shaka-bot reopen

@TommiRautanen
Copy link
Author

@avelad can you reopen this one?

@shaka-bot shaka-bot reopened this May 3, 2024
@SebastianLjungman
Copy link

Could also possibly be related to #6388? Both this and #6320 were included in the same releases 4.6.16 / 4.7.12

@avelad avelad added component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically labels May 6, 2024
@avelad
Copy link
Collaborator

avelad commented May 6, 2024

@CarlLindqvist your stream/subtitles works fine with manifest.hls.sequenceMode=false, so there are a problem with manifest.hls.sequenceMode=true (default config)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

6 participants