Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing values for DASH role scheme #1149

Closed
dudewheresmycode opened this issue Nov 27, 2022 · 4 comments · Fixed by #1390
Closed

Add missing values for DASH role scheme #1149

dudewheresmycode opened this issue Nov 27, 2022 · 4 comments · Fixed by #1390
Assignees
Labels
component: DASH The issue involves DASH output flag: spec compliance An issue with compliance to DASH, HLS, or other specs

Comments

@dudewheresmycode
Copy link

System info

Operating System: Debian GNU/Linux 11 (bullseye)
Shaka Packager Version: shaka-packager version v2.6.1-634af65-release

Issue and steps to reproduce the problem

I'm running into an issue setting the roles stream descriptor option for content containing descriptive audio tracks. The DASH spec specifically defines these as:

description - Textual or audio media component containing a textual description (intended for
audio synthesis) or an audio description describing a visual component.

From the shaka-packager docs, it appears it only supports a subset of the values outlined in the DASH specification:

Optional semicolon separated list of values for DASH Role element. The value should be one of: caption, subtitle, main, alternate, supplementary, commentary and dub. See DASH (ISO/IEC 23009-1) specification for details.

However, checking the DASH (ISO/IEC 23009-1) specification, section 5.8.5.5 DASH role scheme (Table 29), defines many more values for the roles:

  • caption
  • subtitle
  • main
  • alternate
  • supplementary
  • commentary
  • dub
  • description
  • sign
  • metadata
  • enhanced-audio-intelligibility
  • emergency

Packager Command:

shaka-packager \
in=./input.mp4,stream=video,init_segment=./video/video_init.mp4,segment_template=./video/video_$Number$.m4s \
in=./input.mp4,stream=audio,language=en,roles=main,init_segment=./audio/audio_main_init.mp4,segment_template=./audio/audio_main_$Number$.m4s \
in=./descriptive-audio.mp4,stream=audio,language=en,roles=description,init_segment=./audio/audio_desc_init.mp4,segment_template=./audio/audio_desc_$Number$.m4s \
--fragment_duration 6 --segment_duration 6 --generate_static_live_mpd --mpd_output ./manifest.mpd

Extra steps to reproduce the problem?
(1) include roles=description in DASH stream descriptor options

What is the expected result?
Generates a DASH manifest with a description role

What happens instead?
Shaka throws an error:

[1127/214613:ERROR:period.cc(208)] Unrecognized role 'description'
@dudewheresmycode
Copy link
Author

dudewheresmycode commented Nov 27, 2022

I see that support for description specifically was added in this commit, so I'm guessing this just hasn't made it into a release yet? Any chance you could tag a new release?

@dudewheresmycode
Copy link
Author

Just wanted to check in on this. Any chance we can get a new release tagged that contains this fix?

@dudewheresmycode
Copy link
Author

Just wanted to bump this again. Any chance we could get a new release tagged? The fix for this was merged nearly a year ago now.

@cosmin
Copy link
Collaborator

cosmin commented Apr 26, 2024

version 3.0.x should contain anything that was previously merged, I'll look at adding any missing values

@cosmin cosmin self-assigned this Apr 26, 2024
@cosmin cosmin added this to the v3.1 milestone Apr 26, 2024
@cosmin cosmin added flag: spec compliance An issue with compliance to DASH, HLS, or other specs component: DASH The issue involves DASH output labels Apr 26, 2024
@github-actions github-actions bot removed this from the v3.1 milestone Apr 26, 2024
cosmin added a commit that referenced this issue Apr 30, 2024
)



Fixes #1149

---------

Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves DASH output flag: spec compliance An issue with compliance to DASH, HLS, or other specs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants