-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librange: initial combo points lost due to client timing issues #1263
Comments
I can confirm the same issue. Raiding on a druid is not possible with current PFUI(feral cat). Sometimes it will generate combo points and others i get nothing for entire mobs. It ONLY happens in raid and with a group of people. Everything works fine solo or even in a raid by myself. |
I can confirm this too, and the reason why it happens seems to have to do something with "click to cast" mouseover. |
I can also confirm this is the case as of last Saturday. It seems to have gotten better but not entirely resolved. This has been going on for over a month for me for sure. I started noticing it in aq40 raid. |
bump @shagu |
I can't help here, because I was never able to reproduce the issue on my druid. The only automatic target-change that happens is inside the 40y range check emulation, which was already fixed by @gwetchen(d7a7387). If there's still issues with that, please try to disable the 40y rangecheck and see if it gets better. The other target-switch that can happen is when using mouseover macros or focus-frame casts, but that's something which cannot be fixed in vanilla. Because It will always silently switch target to cast the spell and then switch back. Also, are you sure it's not related to any other target-changing addons like HonorSpy, NPCScan, UnitScan, etc? Please let me know if you find a way to reproduce with only pfUI and I'll gladly help to fix the issue. |
hey @shagu , in my case this is a newish issue. I have been using PFUI for a while and it was fine. Only started bugging out a few months ago. So I'm thinking of doing the following to troubleshoot: -clean install of turtlewow with no other addons other than PFUI If that is successful, then I will reinstall the addons I currently have one at a time until it triggers the issue. If it doesnt fix it then perhaps you can help suggest things to disable such as the 40y range check. I'll also record my screen if it persists. This is a bit tricky to test since I can only replicate it in raids. Any other suggestions that might be helpful to test? thanks! |
@shagu ill also try disabling the 40y check first and let you know. |
Could you implement a check that the mouseover casting for raid frames is disabled as long as the druid is in cat form? |
No, there are way too many people that rely on the mouseover to quickly throw and innvervate, battlerez or heal. |
I have no other ideas what could possibly switch targets or confuse the 40y range check. |
Finally I found a way to reproduce it at the training dummies in orgrimmar.
It's now visible how 1-2 combo points appear for a very short time and directly disappear again. As it is nice to know a way to reproduce, it is also sad why it happens: After quite some time of debugging it turned out that both event checks ( Sadly, there's also no other usable event fired, that could be use to put in another delay, right after the opener is pressed. So the only way to fix it, would be to disable the 40y-range-check entirely while being in cat form. And therefore turning it back from 40y to the game default of 28y while in this form. |
Would that be hard to implement disabling the 40y range check automatically while in cat form and enabling it back when out of cat? |
No, that would be quite easy. It's just that I'm not happy with it at all. I'd like to give myself and others more time to think about it. Maybe there's another solution that I just can't see right now. |
Thanks everyone for the feedback. I tried using a clean client, only installing the latest version of pfui, and went to Zul'Gurub with friends. The same issue still occurred when fighting Hakkar. So I'm pretty sure the problem lies with pfui. It seems like Shagu has already found the issue, looking forward to the day it gets fixed. |
Simply turning off the 40 yr check in the pfui settings worked as @shagu suggested! I tested it in Naxx yesterday. |
confirmed, worked for me aswell in pve and pvp... sad there is no workaround |
This issue is stale because it has been open for 30 days with no activity. |
As nothing better came to my mind and also no further ideas came up, I have now disabled the 40y range check while being in cat form. (Cat detection is done by checking for class == druid and powertype == energy) "Fixed" via: 7e0990c |
I saw a fix what was made for the issue of missing combo points. I actually noticed this problem a few months ago, but I didn't report it at the time. Instead, I just switched to using a different UI addon. After seeing the fix was made, I downloaded the new pfUI to use.
However, in recent raids, I still noticed instances of missing combo points. Unfortunately, I didn't record it, but it definitely happened. It usually occurs at the beginning of a boss fight and then doesn't happen again. I couldn't reproduce the issue in target dummy testing. I hope my feedback catches your attention and the issue gets fixed soon. pfUI is a great addon, I like it.
The text was updated successfully, but these errors were encountered: