Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement join controlling functions #480

Closed
wants to merge 3 commits into from
Closed

implement join controlling functions #480

wants to merge 3 commits into from

Conversation

billdenney
Copy link
Collaborator

Fixes #427

Implements join controlling functions. See the examples in the help file for usage.

@codecov
Copy link

codecov bot commented Apr 15, 2022 •
edited

Codecov Report

Merging #480 (5cd80fc) into main (ab90c1a) will increase coverage by 0.12%.
The diff coverage is 96.74%.

❗ Current head 5cd80fc differs from pull request most recent head cb848f6. Consider uploading reports for the commit cb848f6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   99.53%   99.66%   +0.12%     
==========================================
  Files          23       24       +1     
  Lines        1084     1207     +123     
==========================================
+ Hits         1079     1203     +124     
+ Misses          5        4       -1
Impacted Files Coverage Δ
R/join_control.R 96.74% <96.74%> (ø)
R/clean_names.R 100.00% <0.00%> (+45.45%) ⬆️

@billdenney billdenney mentioned this pull request Apr 15, 2022
Open
@billdenney billdenney mentioned this pull request Jun 24, 2022
Closed
@sfirke
Copy link
Owner

sfirke commented Jan 4, 2023

Would you like me to review this (a) in general (b) for inclusion in 2.2 this month?

@billdenney
Copy link
Collaborator Author

Let's not jump on this yet. The new dplyr functionality will need to integrate with this, so I'd rather wait for that than do something that may cause a conflict now.

@sfirke
Copy link
Owner

sfirke commented Jan 4, 2023

Sounds good. I am looking at the other requests/issues for v2.2 and sweating a little bit so it sounds like a good allocation of time for me to focus on those instead!

@billdenney
Copy link
Collaborator Author

I think that the new dplyr functionality covers most of this PR, so I'm closing it now.

@billdenney billdenney closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: join_many_to_one() and join_one_to_one()
2 participants
@billdenney @sfirke