Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request]: support avif for background #87

Open
jefBinomed opened this issue Nov 9, 2022 · 5 comments · May be fixed by #99
Open

[Request]: support avif for background #87

jefBinomed opened this issue Nov 9, 2022 · 5 comments · May be fixed by #99
Labels
bug Something isn't working

Comments

@jefBinomed
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

Supporter les format avif pour les background

Describe alternatives you've considered

No response

Additional context

No response
@jefBinomed jefBinomed added the bug Something isn't working label Mar 8, 2023
@jefBinomed jefBinomed added this to the 3.1.0 milestone Mar 8, 2023
shepard8 added a commit that referenced this issue Mar 9, 2023
@shepard8
#87 - support avif format
7507836
shepard8 added a commit that referenced this issue Mar 9, 2023
@shepard8
#87 - case insensitive CSS selectors for image formats.
3e2f0dc
@shepard8
Copy link
Contributor

shepard8 commented Mar 9, 2023 •
edited

To support this last commit, please see CSS documentation at mozilla and browser support at CanIUse.

@shepard8
Copy link
Contributor

shepard8 commented Mar 9, 2023

Note that commit 7507836 allows avif files for the layout added by sfeir-school-theme, but not for the classic RevealJS slides.

The classical way is to fill in a feature request in RevealJS and wait. However I'm not really a patient person, hence I'll use patch-package to add avif to the list of allowed local background formats.

@shepard8
Copy link
Contributor

shepard8 commented Mar 9, 2023

Well my ambitions were probably too high. Patching the src folder is not enough, I need to patch dist as well. The problem is that virtually any update will need the patch to be updated. So that's not a viable option unfortunately. I'll open an issue at RevealJS and this issue will solve itself automatically at some point.

@shepard8
Copy link
Contributor

shepard8 commented Mar 9, 2023

The issue has been created at the RevealJS repository.

shepard8 added a commit that referenced this issue Mar 9, 2023
@shepard8
#87 - demo updated.
4875596
@shepard8 shepard8 linked a pull request Mar 9, 2023 that will close this issue
Open
@shepard8 shepard8 linked a pull request Mar 9, 2023 that will close this issue
#87 Support avif file format for backgrounds #99
Open
shepard8 added a commit that referenced this issue Mar 10, 2023
@shepard8
#87 Patch RevealJS to support AVIF on the fly.
f1bac03
shepard8 added a commit that referenced this issue Mar 10, 2023
@shepard8
#87 Revert fake file extension.
08a06ed
shepard8 added a commit that referenced this issue Mar 10, 2023
@shepard8
#87 patch-package and forgot to change one file extension in demo.
833b07d
@jefBinomed jefBinomed modified the milestones: 3.1.0, 3.2.0 Jan 11, 2024
jefBinomed pushed a commit that referenced this issue Apr 15, 2024
@shepard8 @jefBinomed
#87 - support avif format
faad064
jefBinomed pushed a commit that referenced this issue Apr 15, 2024
@shepard8 @jefBinomed
#87 - case insensitive CSS selectors for image formats.
067a37c
jefBinomed pushed a commit that referenced this issue Apr 15, 2024
@shepard8 @jefBinomed
#87 - demo updated.
232281a
jefBinomed pushed a commit that referenced this issue Apr 15, 2024
@shepard8 @jefBinomed
#87 Patch RevealJS to support AVIF on the fly.
b933709
jefBinomed pushed a commit that referenced this issue Apr 15, 2024
@shepard8 @jefBinomed
#87 Revert fake file extension.
23ff32a
jefBinomed pushed a commit that referenced this issue Apr 15, 2024
@shepard8 @jefBinomed
#87 patch-package and forgot to change one file extension in demo.
439e37c
@jefBinomed jefBinomed removed this from the 3.2.0 milestone Apr 15, 2024
@jefBinomed
Copy link
Collaborator Author

Toujours en attente de gestion de la part de reveal... Du coup, reporté à une autre milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#87 Support avif file format for backgrounds sfeir-open-source/sfeir-school-theme
2 participants
@jefBinomed @shepard8