Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mach to let paths in spaces #9616

Open
wafflespeanut opened this issue Feb 12, 2016 · 7 comments
Open

Fix mach to let paths in spaces #9616

wafflespeanut opened this issue Feb 12, 2016 · 7 comments
Labels
A-build Related to or part of the build process L-python Python is required

Comments

@wafflespeanut
Copy link
Contributor

#9442 is not only an issue for Windows, but for all platforms, i.e., mach exits if there's space in its path. Though #9601 adds a helpful suggestion, we should fix it.

@wafflespeanut wafflespeanut added L-python Python is required A-build Related to or part of the build process labels Feb 12, 2016
@larsbergstrom
Copy link
Contributor

This should also include CI tests for all of our build platforms (Windows, OSX, and Linux), as it's super-easy to either break it or pick up a new dependency that doesn't support spaces in paths.

@tigercosmos
Copy link
Contributor

I tried this for a while. Space will just cause lots of problems. LOL

@tigercosmos
Copy link
Contributor

tigercosmos commented Oct 19, 2017

Even virtualenv has not solved space issue yet. pypa/virtualenv#53

@tigercosmos
Copy link
Contributor

@wafflespeanut How do you think if we work at a tmp folder then mv to servo and delete tmp in "space path case". This can solve this issue in another way.

@pradyunsg
Copy link

virtualenv has fixed this. Is this still a problem for servo?

@jdm
Copy link
Member

jdm commented Mar 6, 2019

Ooh, sounds like we should update the version of virtualenv we rely on.

@pshaughn
Copy link
Member

I observed something that I think falls under this: mach will quickly print an informative error and exit if it's being run in a directory that itself contains spaces, but if it's being run in a spaceless one while $HOME does contain spaces, it will instead try to run and then print a much less informative error about not being able to access the Cargo configuration. An explicit check for spaces in the user's home directory, around the same place it's already checking for them in the working directory, could make things friendlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Related to or part of the build process L-python Python is required
Projects
None yet
Development

No branches or pull requests

6 participants