New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mach
to let paths in spaces
#9616
Comments
This should also include CI tests for all of our build platforms (Windows, OSX, and Linux), as it's super-easy to either break it or pick up a new dependency that doesn't support spaces in paths. |
I tried this for a while. |
Even |
@wafflespeanut How do you think if we work at a |
virtualenv has fixed this. Is this still a problem for servo? |
Ooh, sounds like we should update the version of virtualenv we rely on. |
I observed something that I think falls under this: mach will quickly print an informative error and exit if it's being run in a directory that itself contains spaces, but if it's being run in a spaceless one while $HOME does contain spaces, it will instead try to run and then print a much less informative error about not being able to access the Cargo configuration. An explicit check for spaces in the user's home directory, around the same place it's already checking for them in the working directory, could make things friendlier. |
#9442 is not only an issue for Windows, but for all platforms, i.e.,
mach
exits if there's space in its path. Though #9601 adds a helpful suggestion, we should fix it.The text was updated successfully, but these errors were encountered: