Update WebView variants of ConstellationMsg #32163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
approved these changes
Apr 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Sorry I forgot the first webview is a special case and it needs to send the message as well. |
wusyong
force-pushed
the
webview_variants
branch
from
5968017
to
bd4c956
Compare
mrobinson
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a few webview variants in
ConstellationMsgenum:ConstellationMsg::WebViewOpenedto make sure a webview is added to constellation and compositor before sendingEmbedderEvent::WebViewOpenedto embedder.MoveResizeWebView,ShowWebView,HideWebView,RaiseWebViewToTopvariants because they are not called. Servo instance will call compositor methods directly without sending to constellation. This should make it clear that these event won't come to constellation and simplify the workflow../mach build -ddoes not report any errors./mach test-tidydoes not report any errors