New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract generated class constructor hook into handwritten functions #31571
Comments
@jdm @mrobinson would like to take on this task |
@servo-highfive assign me |
Hey @MunishMummadi! Thanks for your interest in working on this issue. It's now assigned to you! |
Hey @jdm . I would love to work on this issue. Can you mentor me for this issue. I understood what to do. But it seems little overwhelming. |
Yes, I'm happy to answer questions about it |
@jdm . I am sorry to say this. I tried my best. But I failed. Thank you for the heads up. You can unassign me. |
@jdm Went through the issue and need a few clarifications: Because the highlighted code section in (difficult to read) shows code line numbers from 6175-6212 |
Thanks for checking! servo/components/script/dom/bindings/codegen/CodegenRust.py Lines 6111 to 6172 in 5d518ca
|
@servo-highfive @jdm Just one more additional help needed here. I have performed some code changes for this PR. |
If the page loads like it did before, I would expect that's good enough for a PR. We can run the full automated test suite to verify the changes. |
Hello @jdm attempted this issue and created PR #31949 but would like a litte guidance . |
|
Hello Thank you for the guidance made a bit more changes can you help me with this one last query
|
Hello @sagudev a bit more help please, struggling to make build here . In my rust code (which I have separated in |
I am not sure if I understand error, it better to use ``` blocks when having code of multiple lines. From what I see in PR you need to be more careful what is python and what is rust. Codegen (python code) generates rust code (this is usually done with strings manipulation). |
The output of CGClassConstructHook is difficult to read. By following the model of #31569 and creating two generic helper functions that cover both cases (isHTMLConstructor is true/false), it will be easier to read and modify this code in the future.
Part of #31570.
The text was updated successfully, but these errors were encountered: