Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "same-origin" referrer policy in Request.webidl #25680

Closed
pshaughn opened this issue Feb 3, 2020 · 3 comments · Fixed by #26006
Closed

Add "same-origin" referrer policy in Request.webidl #25680

pshaughn opened this issue Feb 3, 2020 · 3 comments · Fixed by #26006
Labels
A-content/dom Interacting with the DOM from web content A-network C-assigned There is someone working on resolving the issue I-spec-update

Comments

@pshaughn
Copy link
Member

pshaughn commented Feb 3, 2020 •
edited

https://fetch.spec.whatwg.org/#concept-request-referrer-policy points at https://w3c.github.io/webappsec-referrer-policy/#referrer-policy which we don't quite match the IDL for. Methods in request.rs are currently conflating "origin" and "same-origin" together in Into<ReferrerPolicy> for MsgReferrerPolicy.

A nearby comment mentions whatwg/fetch#346, which ended up closed without merging; that comment should get taken out when fixing this.
@jdm jdm added A-content/dom Interacting with the DOM from web content A-network I-spec-update labels Feb 10, 2020
@tipowol
Copy link
Contributor

tipowol commented Mar 20, 2020

@highfive assign me

@highfive highfive added the C-assigned There is someone working on resolving the issue label Mar 20, 2020
@highfive
Copy link

Hey @tipowol! Thanks for your interest in working on this issue. It's now assigned to you!

@jdm
Copy link
Member

jdm commented Mar 20, 2020

It will be useful to run ./mach test-wpt tests/wpt/web-platform-tests/fetch/api after fixing this.

@tipowol tipowol mentioned this issue Mar 20, 2020
Merged
4 tasks
bors-servo pushed a commit that referenced this issue Mar 20, 2020
Auto merge of #26006 - tipowol:fix-25680, r=<try>
37bf210 
Add missing same-origin referrer policy

<!-- Please describe your changes on the following line: -->

These changes add missing same-origin ReferrerPolicy in Request.webidl.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25680 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content A-network C-assigned There is someone working on resolving the issue I-spec-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing same-origin referrer policy tipowol/servo
4 participants
@jdm @pshaughn @highfive @tipowol