Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a tool to show the build status of a PR #19853

Closed
jdm opened this issue Jan 24, 2018 · 3 comments
Closed

Create a tool to show the build status of a PR #19853

jdm opened this issue Jan 24, 2018 · 3 comments
Assignees
Labels
B-high-value Represents work that would have a big impact B-interesting-project Represents work that is expected to be interesting in some fashion E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss

Comments

@jdm
Copy link
Member

jdm commented Jan 24, 2018

Currently we use http://build.servo.org/grid and http://build.servo.org/console to see the build status of a particular revision across all platforms. Neither of these views are really ideal for that purpose. We should build a tool that allows users to provide a PR number, then looks in the buildbot history to find current and historical builds related to that PR. The output should be a webpage, so I would expect this tool to be written as a Flask server in Python or some equivalent in node.js, or even just entirely client-side using JavaScript and XMLHttpRequest.

To acquire the build data, we can use the buildbot JSON API.

  1. Get the list of builders
  2. For each builder, get the build data for each cached build
  3. If the build data's comments includes the PR number, mark that build as important
  4. For each important build, use the build's text of "successful" to determine if the build succeeded
  5. For each builder, if there is a currentBuild then perform the same steps but mark any important builds as in-progress
  6. Display the list of important builds and their statuses by grouping them according to the actual source revision the builds were based on, and according to the platform associated with each builder
@jdm jdm added B-interesting-project Represents work that is expected to be interesting in some fashion E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss B-high-value Represents work that would have a big impact labels Jan 24, 2018
@tigercosmos
Copy link
Contributor

This is really helpful.

@ferjm ferjm self-assigned this Jan 25, 2018
@jdm
Copy link
Member Author

jdm commented Jan 30, 2018

There's an initial version of this tool in https://github.com/servo/buildbotstatus/ courtesy of @ferjm. We'll file issues on improving it there.

@jdm jdm closed this as completed Jan 30, 2018
@ferjm
Copy link
Contributor

ferjm commented Mar 20, 2018

This is now live in https://servo.github.io/buildbotstatus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-high-value Represents work that would have a big impact B-interesting-project Represents work that is expected to be interesting in some fashion E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss
Projects
None yet
Development

No branches or pull requests

3 participants