Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web_accessible context #36

Closed
wants to merge 8 commits into from
Closed

Conversation

martonlederer
Copy link

@martonlederer martonlederer commented Sep 11, 2022

Closes #35 and #12

  • Adds web_accessible context for pages in web_accessible_resources
  • Fixes communication between the background script and web_accessible_resources pages
  • Fixes invalid context type (background) with messages from web_accessible_resources pages
  • Adds documentation about the new context

@martonlederer martonlederer marked this pull request as ready for review September 11, 2022 13:56
@martonlederer
Copy link
Author

✅ Ready for review + tested with onMessage and sendMessage (with tabId as destination)

@thanhlmm
Copy link

thanhlmm commented Sep 22, 2022

Hi @martonlederer , what needs to be done to make this MR merged? We also have this issue and want to fix it asap

@martonlederer
Copy link
Author

The pr is ready, but it doesn't seem like the developer os merging a lot of prs. Let's hope it gets merged asap :)

@thanhlmm
Copy link

Hi @zikaari , can we move this PR forward?

@zikaari
Copy link
Collaborator

zikaari commented Sep 22, 2022

Apologies for the long delay folks, I've been working on a very important problem with webext-bridge.

@martonlederer Thank you the effort! v5.0.0 is no longer under development, please use the new framework available in next branch of this repo. Fortunately it is actually less work than what you have done already.

It is as simple as createEndpointRuntime('<endpoint_name>', <routing handler>), see implementation for popup or window as a reference.

Also see the CHANGELOG in next branch to get up to speed on upcoming major release of v6.0.0.

@martonlederer
Copy link
Author

Wow thank you! That's amazing

@zikaari
Copy link
Collaborator

zikaari commented Sep 27, 2022

@martonlederer You dropped the PR, Is it working with next branch somehow?

@martonlederer
Copy link
Author

@zikaari haven't been able to test that yet, I didn't have time to update my extension with it, so rn I just published my patch to npm, so it works temporary. Once I'm done with everything else, I'm gonna try and test it :)

@thanhlmm
Copy link

thanhlmm commented Oct 2, 2022

Hi @martonlederer, I wonder that can you share your publishing package? I need it on my project as well

Thank you for your hard work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for web_accessible_resources contexts
3 participants