Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resultTtlInSeconds defaults to 300 when set to 0 #2587

Closed
tomyam1 opened this issue Nov 1, 2016 · 3 comments · Fixed by #2588
Closed

resultTtlInSeconds defaults to 300 when set to 0 #2587

tomyam1 opened this issue Nov 1, 2016 · 3 comments · Fixed by #2588
Labels
bug

Comments

@tomyam1
Copy link

tomyam1 commented Nov 1, 2016

This is a Bug Report

Description

  • What went wrong?

resultTtlInSeconds defaults to 300 when set to 0.

This is oviously due to this line (since 0 is falesy...)
@tomyam1 tomyam1 changed the title Cannot set resultTtlInSeconds: 0 resultTtlInSeconds defaults to 300 when set to 0 Nov 1, 2016
@flomotlik flomotlik added the bug label Nov 1, 2016
@flomotlik
Copy link
Contributor

Yup thats a bug that needs to be resolved. Thanks

@horike37 horike37 mentioned this issue Nov 1, 2016
Merged
6 tasks
@horike37
Copy link
Member

horike37 commented Nov 1, 2016

@flomotlik
I fixed it. Please review.

@OlegRakovitch
Copy link

Facing same issue. Hope suggested bug fix will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed the bug resultTtlInSeconds defaults to 300 when set to 0
4 participants
@flomotlik @horike37 @tomyam1 @OlegRakovitch