Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a context manager to open product #133

Open
jteulade opened this issue Apr 3, 2024 · 1 comment · May be fixed by #134
Open

Add a context manager to open product #133

jteulade opened this issue Apr 3, 2024 · 1 comment · May be fixed by #134
Assignees
@jteulade
Labels
0.22.0 For version 0.22.0 enhancement New feature or request

Comments

@jteulade
Copy link
Contributor

jteulade commented Apr 3, 2024 •
edited

When you open a product with the method Reader().open(...), you have to delete the product at the end.
Otherwise, if your program open a lot of products, you can have a space problem.

With a context manager, you can have a clearer code without a try finally statement.
@jteulade jteulade added the enhancement New feature or request label Apr 3, 2024
@remi-braun remi-braun added the 0.22.0 For version 0.22.0 label Apr 3, 2024
@remi-braun
Copy link
Member

Very nice feature to have, indeed 😉

@jteulade jteulade self-assigned this Apr 3, 2024
jteulade added a commit that referenced this issue Apr 3, 2024
@jteulade
Feat #133: add context manager for Reader.open method
f15c895
@jteulade jteulade linked a pull request Apr 3, 2024 that will close this issue
Feat #133: add context manager for Reader.open method #134
Draft
2 tasks
jteulade added a commit that referenced this issue May 15, 2024
@jteulade
Feat #133: add context manager for Reader.open method
d05b725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jteulade jteulade

Labels
0.22.0 For version 0.22.0 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat #133: add context manager for Reader.open method sertit/eoreader
2 participants
@jteulade @remi-braun