Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RandomService#nextString has too big default value for length param #98

Open
serpro69 opened this issue Oct 26, 2021 · 0 comments
Open
Labels
core 🧬 Issue related to :core module enhancement 🚀 New feature or request
Milestone

Comments

@serpro69
Copy link
Owner

Not that it's a big issue, since it can always be explicitly provided with a different len, but it could be preferable to reduce the default length because this function is used in generation of random class instance functionality with default length of 100.

This could be considered a breaking change though, so will be postponed until next major release.

@serpro69 serpro69 added enhancement 🚀 New feature or request core 🧬 Issue related to :core module labels Oct 26, 2021
@serpro69 serpro69 modified the milestones: 1.9.0, 2.0.0 Oct 26, 2021
@serpro69 serpro69 modified the milestones: 1.10.0, 2.0.0 Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core 🧬 Issue related to :core module enhancement 🚀 New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant