Natively support JSON.NET dynamic objects (JObject)

[ChristianWeyer]

On Twitter you mentioned that it should be fairly straightforward to implement via IDestructuringPolicy
;)

[kkozmic]

I was trying to get this working via IDestructuringPolicy but, I'm afraid it won't work.

Cursory look through the codebase seems to indicate (here https://github.com/serilog/serilog/blob/master/src/Serilog/Parameters/PropertyValueConverter.cs?source=c#L112) that PropertyValueConverterfirst treats the objects as a collection (all JTokens are IEnumerable) and therefore never bothers checking with IDestructuringPolicy.

I think perhaps giving the IDestructuringPolicy a higher priority (checking with it first, and then falling back to the default behaviour) might offer a way out, but I may be completeley wrong, I only spent 2 minutes looking at this code.

[kkozmic]

I created a quick workaround for now by... adding a level of indirection.

I added a class called JObjectWrapper that is not IEnumerable and I wrap my JObject with it. Now my IDestructuringPolicy gets called and the world is a happy place again.

[nblumhardt]

@kkozmic how's this one turning out? Worth us removing the limitation you mention above? Any other thoughts? Cheers :)

[kkozmic]

well, it's a nasty workaround :) It gets me where I need to be but I'd rather have a more elegant solution than that if possible.

[Jaben]

New interface, perhaps?

public interface ISequenceConversionPolicy
{
   bool TryConvertToSequence(object value, ILogEventPropertyValueFactory propertyValueFactory, out SequenceValue result);
}

Also, maybe:

public interface IDictionaryConversionPolicy

:)

[nblumhardt]

Closing for now, but open to working through this one if anyone's keen to try a PR. Thanks for all the input folks! :)

[mcintyre321]

@kkozmic Any chance I could take a look at your IDestructuringPolicy (the one that works with the wrapper)?

[kkozmic]

Sorry, I don't have that code with me anymore.

On Tue Feb 03 2015 at 4:38:45 AM Harry McIntyre notifications@github.com
wrote:

@kkozmic https://github.com/kkozmic Any chance I could take a look at
your IDestructuringPolicy (the one that works with the wrapper)?

—
Reply to this email directly or view it on GitHub
#30 (comment).

[nblumhardt]

#371 echoes this one, I think it's one for us to reopen, but might be a "2.0"

[nblumhardt]

Build 1.4.168 removes the limitation that made this awkward; would love to see a Serilog.Extras.JObject or similar that takes advantage of it :-)

Thanks @Jaben for nailing this!

[nblumhardt]

https://github.com/destructurama/json-net

[mcintyre321]

Nice!

[CumpsD]

@nblumhardt that's awesome, thanks!